Split NVCF generator into completion chat #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o take extra params from config
|
ps. i know, i know, sorry about the _config indexing jeffrey |
One would hope so! I like where this is going. |
Co-authored-by: Jeffrey Martin <jemartin@nvidia.com> Signed-off-by: Leon Derczynski <leonderczynski@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVCF models support at least two interfaces - Completion and Chat styles. They also sometimes require custom headers. This PR splits the NVCF class into two, one for each interface, providing separate methods for building the payload and parsing the output under each interface style. It also adds code to allow external configuration of the payload fields that the NVCF endpoint is queried with.