Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator & detector structure validation #702

Merged
merged 7 commits into from
May 28, 2024
Merged

generator & detector structure validation #702

merged 7 commits into from
May 28, 2024

Conversation

leondz
Copy link
Collaborator

@leondz leondz commented May 27, 2024

  • tests for generator class methods & signatures
  • tests for detector class methods & signatures
  • generator.base.generate() no longer strips Nones
  • garak custom exceptions module
  • detector.detect() validation

@leondz leondz mentioned this pull request May 27, 2024
Closed
@leondz leondz requested a review from jmartin-tech May 27, 2024 12:30
jmartin-tech
jmartin-tech reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one naming idea noted.

garak/failure.py Outdated Show resolved Hide resolved
@leondz leondz merged commit 85a6270 into main May 28, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@leondz leondz deleted the feature/generator_detector_structure_validation branch May 29, 2024 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmartin-tech jmartin-tech jmartin-tech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leondz @jmartin-tech