only set generations if still default #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generations is set via config ignore the constructor provided value. Planned revision to `Generator` will remove `generations` from the constructor furher ensuring the value is default or supplied on a `config_root`. * only set generations if still matches default * expand Cohere defaults to include `Generator` defaults * restore `test_attempts` line selection with note about `why` the line is correct Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
leondz
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generations is set via config ignore the constructor provided value.
Planned revision to
Generatorwill removegenerationsfrom the constructor furher ensuring the value is default or supplied on aconfig_root.Generatordefaultstest_attemptsline selection with note aboutwhythe line is correct