Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct sorting for set json in plugin_cache.json #794

Merged
merged 2 commits into from
Jul 22, 2024
Merged

correct sorting for set json in plugin_cache.json #794

merged 2 commits into from
Jul 22, 2024

Conversation

jmartin-tech
Copy link
Collaborator

Update uses sorted(obj) instead of a post obj.sort() to return the sorted object instead of None due to sort in place.

@jmartin-tech
json cache set sorting
4efc234 
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
@jmartin-tech
update plugin_cache.json
de08503 
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
erickgalinkin
erickgalinkin approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pretty straightforward fix.

@jmartin-tech jmartin-tech merged commit e8bb254 into NVIDIA:main Jul 22, 2024
8 checks passed
@jmartin-tech jmartin-tech deleted the fix/correct-set-sorting branch July 22, 2024 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erickgalinkin erickgalinkin erickgalinkin approved these changes

@leondz leondz Awaiting requested review from leondz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartin-tech @erickgalinkin