Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrections to config format for TAP internal generators #796

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

jmartin-tech
Copy link
Collaborator

More cruft found from #711 & #742

  • ensure name is set
  • wrap config in required Configurable structure

Testing:

python -m garak -m huggingface.Model -n meta-llama/Llama-2-7b-chat-hf -p tap.TAP

* ensure `name` is set
* wrap config in required `Configurable` structure

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
@jmartin-tech jmartin-tech merged commit 6b40f03 into NVIDIA:main Jul 22, 2024
8 checks passed
@jmartin-tech jmartin-tech deleted the fix/tap-generator-config branch July 22, 2024 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants