Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAMI func to get AMI based on region #63

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

ArangoGutierrez
Copy link
Collaborator

No description provided.

pkg/provider/aws/dryrun.go Outdated Show resolved Hide resolved
pkg/provider/aws/dryrun.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/provider/aws/create.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator Author

@elezar PTAL, all comments have been addressed

holodeck.yml Outdated Show resolved Hide resolved
pkg/provider/aws/create.go Outdated Show resolved Hide resolved
pkg/provider/aws/dryrun.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the dictionary branch 2 times, most recently from e756ccb to 93a7ede Compare May 24, 2024 08:36
@ArangoGutierrez ArangoGutierrez requested a review from elezar May 24, 2024 08:37
@ArangoGutierrez
Copy link
Collaborator Author

@elezar PTAL, all comments have been addressed

pkg/provider/aws/create.go Outdated Show resolved Hide resolved
pkg/provider/aws/dryrun.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
pkg/provider/aws/image.go Outdated Show resolved Hide resolved
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez ArangoGutierrez merged commit b7e0384 into main Jul 29, 2024
3 checks passed
@ArangoGutierrez ArangoGutierrez deleted the dictionary branch July 29, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants