Merge pull request #487 from elezar/bump-v0.14.4

Bump v0.14.4

.github/workflows/image.yaml

@@ -56,7 +56,7 @@ jobs:
           fi
           echo "PUSH_ON_BUILD=${GENERATE_ARTIFACTS}" >> $GITHUB_ENV
           echo "BUILD_MULTI_ARCH_IMAGES=${GENERATE_ARTIFACTS}" >> $GITHUB_ENV
-      s- name: Set up QEMU
+      - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3

README.md

@@ -124,7 +124,7 @@ Once you have configured the options above on all the GPU nodes in your
 cluster, you can enable GPU support by deploying the following Daemonset:
 
 ```shell
-$ kubectl create -f https://raw.githubusercontent.com/NVIDIA/k8s-device-plugin/v0.14.3/nvidia-device-plugin.yml
+$ kubectl create -f https://raw.githubusercontent.com/NVIDIA/k8s-device-plugin/v0.14.4/nvidia-device-plugin.yml
 ```
 
 **Note:** This is a simple static daemonset meant to demonstrate the basic
@@ -462,11 +462,11 @@ $ helm repo add nvdp https://nvidia.github.io/k8s-device-plugin
 $ helm repo update
 ```
 
-Then verify that the latest release (`v0.14.3`) of the plugin is available:
+Then verify that the latest release (`v0.14.4`) of the plugin is available:
 ```
 $ helm search repo nvdp --devel
 NAME                     	  CHART VERSION  APP VERSION	DESCRIPTION
-nvdp/nvidia-device-plugin	  0.14.3	 0.14.3		A Helm chart for ...
+nvdp/nvidia-device-plugin	  0.14.4	 0.14.4		A Helm chart for ...
 ```
 
 Once this repo is updated, you can begin installing packages from it to deploy
@@ -477,7 +477,7 @@ The most basic installation command without any options is then:
 helm upgrade -i nvdp nvdp/nvidia-device-plugin \
   --namespace nvidia-device-plugin \
   --create-namespace \
-  --version 0.14.3
+  --version 0.14.4
 ```
 
 **Note:** You only need the to pass the `--devel` flag to `helm search repo`
@@ -486,7 +486,7 @@ version (e.g. `<version>-rc.1`). Full releases will be listed without this.
 
 ### Configuring the device plugin's `helm` chart
 
-The `helm` chart for the latest release of the plugin (`v0.14.3`) includes
+The `helm` chart for the latest release of the plugin (`v0.14.4`) includes
 a number of customizable values.
 
 Prior to `v0.12.0` the most commonly used values were those that had direct
@@ -496,7 +496,7 @@ case of the original values is then to override an option from the `ConfigMap`
 if desired. Both methods are discussed in more detail below.
 
 The full set of values that can be set are found here:
-[here](https://github.com/NVIDIA/k8s-device-plugin/blob/v0.14.3/deployments/helm/nvidia-device-plugin/values.yaml).
+[here](https://github.com/NVIDIA/k8s-device-plugin/blob/v0.14.4/deployments/helm/nvidia-device-plugin/values.yaml).
 
 #### Passing configuration to the plugin via a `ConfigMap`.
 
@@ -535,7 +535,7 @@ EOF
 And deploy the device plugin via helm (pointing it at this config file and giving it a name):
 ```
 $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set-file config.map.config=/tmp/dp-example-config0.yaml
@@ -557,7 +557,7 @@ $ kubectl create cm -n nvidia-device-plugin nvidia-plugin-configs \
 ```
 ```
 $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set config.name=nvidia-plugin-configs
@@ -585,7 +585,7 @@ EOF
 And redeploy the device plugin via helm (pointing it at both configs with a specified default).
 ```
 $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set config.default=config0 \
@@ -604,7 +604,7 @@ $ kubectl create cm -n nvidia-device-plugin nvidia-plugin-configs \
 ```
 ```
 $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set config.default=config0 \
@@ -690,7 +690,7 @@ chart values that are commonly overridden are:
 ```
 
 Please take a look in the
-[`values.yaml`](https://github.com/NVIDIA/k8s-device-plugin/blob/v0.14.3/deployments/helm/nvidia-device-plugin/values.yaml)
+[`values.yaml`](https://github.com/NVIDIA/k8s-device-plugin/blob/v0.14.4/deployments/helm/nvidia-device-plugin/values.yaml)
 file to see the full set of overridable parameters for the device plugin.
 
 Examples of setting these options include:
@@ -699,7 +699,7 @@ Enabling compatibility with the `CPUManager` and running with a request for
 100ms of CPU time and a limit of 512MB of memory.
 ```shell
 $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set compatWithCPUManager=true \
@@ -710,7 +710,7 @@ $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
 Using the legacy Daemonset API (only available on Kubernetes < `v1.16`):
 ```shell
 $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set legacyDaemonsetAPI=true
@@ -719,7 +719,7 @@ $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
 Enabling compatibility with the `CPUManager` and the `mixed` `migStrategy`
 ```shell
 $ helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set compatWithCPUManager=true \
@@ -738,7 +738,7 @@ Discovery to perform this labeling.
 To enable it, simply set `gfd.enabled=true` during helm install.
 ```
 helm upgrade -i nvdp nvdp/nvidia-device-plugin \
-    --version=0.14.3 \
+    --version=0.14.4 \
     --namespace nvidia-device-plugin \
     --create-namespace \
     --set gfd.enabled=true
@@ -793,31 +793,31 @@ Using the default values for the flags:
 $ helm upgrade -i nvdp \
     --namespace nvidia-device-plugin \
     --create-namespace \
-    https://nvidia.github.io/k8s-device-plugin/stable/nvidia-device-plugin-0.14.3.tgz
+    https://nvidia.github.io/k8s-device-plugin/stable/nvidia-device-plugin-0.14.4.tgz
 ```
 
 ## Building and Running Locally
 
 The next sections are focused on building the device plugin locally and running it.
 It is intended purely for development and testing, and not required by most users.
-It assumes you are pinning to the latest release tag (i.e. `v0.14.3`), but can
+It assumes you are pinning to the latest release tag (i.e. `v0.14.4`), but can
 easily be modified to work with any available tag or branch.
 
 ### With Docker
 
 #### Build
 Option 1, pull the prebuilt image from [Docker Hub](https://hub.docker.com/r/nvidia/k8s-device-plugin):
 ```shell
-$ docker pull nvcr.io/nvidia/k8s-device-plugin:v0.14.3
-$ docker tag nvcr.io/nvidia/k8s-device-plugin:v0.14.3 nvcr.io/nvidia/k8s-device-plugin:devel
+$ docker pull nvcr.io/nvidia/k8s-device-plugin:v0.14.4
+$ docker tag nvcr.io/nvidia/k8s-device-plugin:v0.14.4 nvcr.io/nvidia/k8s-device-plugin:devel
 ```
 
 Option 2, build without cloning the repository:
 ```shell
 $ docker build \
     -t nvcr.io/nvidia/k8s-device-plugin:devel \
     -f deployments/container/Dockerfile.ubuntu \
-    https://github.com/NVIDIA/k8s-device-plugin.git#v0.14.3
+    https://github.com/NVIDIA/k8s-device-plugin.git#v0.14.4
 ```
 
 Option 3, if you want to modify the code:
@@ -871,6 +871,11 @@ $ ./k8s-device-plugin --pass-device-specs
 
 ## Changelog
 
+### Version v0.14.4
+
+- Update to refactored go-gpuallocator code. This permanently fixes the NVML_NVLINK_MAX_LINKS value addressed in a
+  hotfix in v0.14.3. This also addresses a bug due to uninitialized NVML when calling go-gpuallocator.
+
 ### Version v0.14.3
 
 - Patch vendored code for new NVML_NVLINK_MAX_LINKS value

RELEASE.md

@@ -9,7 +9,7 @@ Publishing the helm chart is currently manual, and we should move to an automate
 
 # Release Process Checklist
 - [ ] Update the README changelog
-- [ ] Update the README to change occurances of the old version (e.g: `v0.14.3`) with the new version
+- [ ] Update the README to change occurances of the old version (e.g: `v0.14.4`) with the new version
 - [ ] Commit, Tag and Push to Gitlab
 - [ ] Build a new helm package with `helm package ./deployments/helm/nvidia-device-plugin`
 - [ ] Switch to the `gh-pages` branch and move the newly generated package to the `stable` helm repo

deployments/helm/nvidia-device-plugin/Chart.yaml

@@ -2,8 +2,8 @@ apiVersion: v2
 name: nvidia-device-plugin
 type: application
 description: A Helm chart for the nvidia-device-plugin on Kubernetes
-version: "0.14.3"
-appVersion: "0.14.3"
+version: "0.14.4"
+appVersion: "0.14.4"
 kubeVersion: ">= 1.10.0-0"
 home: https://github.com/NVIDIA/k8s-device-plugin
 

deployments/static/extensions-v1beta1-nvidia-device-plugin.yml

@@ -35,7 +35,7 @@ spec:
       # See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
       priorityClassName: "system-node-critical"
       containers:
-      - image: nvcr.io/nvidia/k8s-device-plugin:v0.14.3
+      - image: nvcr.io/nvidia/k8s-device-plugin:v0.14.4
         name: nvidia-device-plugin-ctr
         env:
           - name: FAIL_ON_INIT_ERROR

deployments/static/nvidia-device-plugin-compat-with-cpumanager.yml

@@ -38,7 +38,7 @@ spec:
       # See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
       priorityClassName: "system-node-critical"
       containers:
-      - image: nvcr.io/nvidia/k8s-device-plugin:v0.14.3
+      - image: nvcr.io/nvidia/k8s-device-plugin:v0.14.4
         name: nvidia-device-plugin-ctr
         env:
           - name: FAIL_ON_INIT_ERROR

deployments/static/nvidia-device-plugin-privileged-with-service-account.yml

@@ -124,7 +124,7 @@ spec:
         - env:
             - name: PASS_DEVICE_SPECS
               value: "true"
-          image: nvcr.io/nvidia/k8s-device-plugin:v0.14.3
+          image: nvcr.io/nvidia/k8s-device-plugin:v0.14.4
           name: nvidia-device-plugin-ctr
           securityContext:
             privileged: true

nvidia-device-plugin.yml

@@ -38,7 +38,7 @@ spec:
       # See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
       priorityClassName: "system-node-critical"
       containers:
-      - image: nvcr.io/nvidia/k8s-device-plugin:v0.14.3
+      - image: nvcr.io/nvidia/k8s-device-plugin:v0.14.4
         name: nvidia-device-plugin-ctr
         env:
           - name: FAIL_ON_INIT_ERROR

versions.mk

@@ -14,7 +14,7 @@
 
 MODULE := github.com/NVIDIA/k8s-device-plugin
 
-VERSION  ?= v0.14.3
+VERSION  ?= v0.14.4
 
 # vVERSION represents the version with a guaranteed v-prefix
 vVERSION := v$(VERSION:v%=%)