Skip to content

Commit

Permalink
Merge branch 'upstream-bump-v0.7.3' into 'master'
Browse files Browse the repository at this point in the history
Bump version to v0.7.3

See merge request nvidia/kubernetes/device-plugin!68
  • Loading branch information
klueska committed Dec 22, 2020
2 parents bff876e + 6ce1904 commit e8de9ba
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 22 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ifeq ($(IMAGE),)
REGISTRY ?= nvidia
IMAGE := $(REGISTRY)/k8s-device-plugin
endif
VERSION ?= v0.7.2
VERSION ?= v0.7.3

##### Public rules #####

Expand Down
34 changes: 19 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Once you have configured the options above on all the GPU nodes in your
cluster, you can enable GPU support by deploying the following Daemonset:

```shell
$ kubectl create -f https://raw.githubusercontent.com/NVIDIA/k8s-device-plugin/v0.7.2/nvidia-device-plugin.yml
$ kubectl create -f https://raw.githubusercontent.com/NVIDIA/k8s-device-plugin/v0.7.3/nvidia-device-plugin.yml
```

**Note:** This is a simple static daemonset meant to demonstrate the basic
Expand Down Expand Up @@ -123,7 +123,7 @@ The preferred method to deploy the device plugin is as a daemonset using `helm`.
Instructions for installing `helm` can be found
[here](https://helm.sh/docs/intro/install/).

The `helm` chart for the latest release of the plugin (`v0.7.2`) includes
The `helm` chart for the latest release of the plugin (`v0.7.3`) includes
a number of customizable values. The most commonly overridden ones are:

```
Expand Down Expand Up @@ -191,7 +191,7 @@ rationale behind this strategy can be found
Please take a look in the following `values.yaml` file to see the full set of
overridable parameters for the device plugin.

* https://github.com/NVIDIA/k8s-device-plugin/blob/v0.7.2/deployments/helm/nvidia-device-plugin/values.yaml
* https://github.com/NVIDIA/k8s-device-plugin/blob/v0.7.3/deployments/helm/nvidia-device-plugin/values.yaml

#### Installing via `helm install`from the `nvidia-device-plugin` `helm` repository

Expand All @@ -214,7 +214,7 @@ plugin with the various flags from above.
Using the default values for the flags:
```shell
$ helm install \
--version=0.7.2 \
--version=0.7.3 \
--generate-name \
nvdp/nvidia-device-plugin
```
Expand All @@ -223,7 +223,7 @@ Enabling compatibility with the `CPUManager` and running with a request for
100ms of CPU time and a limit of 512MB of memory.
```shell
$ helm install \
--version=0.7.2 \
--version=0.7.3 \
--generate-name \
--set compatWithCPUManager=true \
--set resources.requests.cpu=100m \
Expand All @@ -234,7 +234,7 @@ $ helm install \
Use the legacy Daemonset API (only available on Kubernetes < `v1.16`):
```shell
$ helm install \
--version=0.7.2 \
--version=0.7.3 \
--generate-name \
--set legacyDaemonsetAPI=true \
nvdp/nvidia-device-plugin
Expand All @@ -243,7 +243,7 @@ $ helm install \
Enabling compatibility with the `CPUManager` and the `mixed` `migStrategy`
```shell
$ helm install \
--version=0.7.2 \
--version=0.7.3 \
--generate-name \
--set compatWithCPUManager=true \
--set migStrategy=mixed \
Expand All @@ -261,7 +261,7 @@ Using the default values for the flags:
```shell
$ helm install \
--generate-name \
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.2.tgz
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.3.tgz
```

Enabling compatibility with the `CPUManager` and running with a request for
Expand All @@ -272,15 +272,15 @@ $ helm install \
--set compatWithCPUManager=true \
--set resources.requests.cpu=100m \
--set resources.limits.memory=512Mi \
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.2.tgz
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.3.tgz
```

Use the legacy Daemonset API (only available on Kubernetes < `v1.16`):
```shell
$ helm install \
--generate-name \
--set legacyDaemonsetAPI=true \
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.2.tgz
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.3.tgz
```

Enabling compatibility with the `CPUManager` and the `mixed` `migStrategy`
Expand All @@ -289,31 +289,31 @@ $ helm install \
--generate-name \
--set compatWithCPUManager=true \
--set migStrategy=mixed \
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.2.tgz
https://nvidia.github.com/k8s-device-plugin/stable/nvidia-device-plugin-0.7.3.tgz
```

## Building and Running Locally

The next sections are focused on building the device plugin locally and running it.
It is intended purely for development and testing, and not required by most users.
It assumes you are pinning to the latest release tag (i.e. `v0.7.2`), but can
It assumes you are pinning to the latest release tag (i.e. `v0.7.3`), but can
easily be modified to work with any available tag or branch.

### With Docker

#### Build
Option 1, pull the prebuilt image from [Docker Hub](https://hub.docker.com/r/nvidia/k8s-device-plugin):
```shell
$ docker pull nvidia/k8s-device-plugin:v0.7.2
$ docker tag nvidia/k8s-device-plugin:v0.7.2 nvidia/k8s-device-plugin:devel
$ docker pull nvidia/k8s-device-plugin:v0.7.3
$ docker tag nvidia/k8s-device-plugin:v0.7.3 nvidia/k8s-device-plugin:devel
```

Option 2, build without cloning the repository:
```shell
$ docker build \
-t nvidia/k8s-device-plugin:devel \
-f docker/amd64/Dockerfile.ubuntu16.04 \
https://github.com/NVIDIA/k8s-device-plugin.git#v0.7.2
https://github.com/NVIDIA/k8s-device-plugin.git#v0.7.3
```

Option 3, if you want to modify the code:
Expand Down Expand Up @@ -367,6 +367,10 @@ $ ./k8s-device-plugin --pass-device-specs

## Changelog

### Version v0.7.3

- Update vendoring to include bug fix for `nvmlEventSetWait_v2`

### Version v0.7.2

- Fix bug in dockfiles for ubi8 and centos using CMD not ENTRYPOINT
Expand Down
2 changes: 1 addition & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Publishing the helm chart is currently manual, and we should move to an automate

# Release Process Checklist
- [ ] Update the README changelog
- [ ] Update the README to change occurances of the old version (e.g: `v0.7.2`) with the new version
- [ ] Update the README to change occurances of the old version (e.g: `v0.7.3`) with the new version
- [ ] Commit, Tag and Push to Gitlab
- [ ] Build a new helm package with `helm package ./deployments/helm/nvidia-device-plugin`
- [ ] Switch to the `gh-pages` branch and move the newly generated package to the `stable` helm repo
Expand Down
4 changes: 2 additions & 2 deletions deployments/helm/nvidia-device-plugin/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: nvidia-device-plugin
type: application
description: A Helm chart for the nvidia-device-plugin on Kubernetes
version: "0.7.2"
appVersion: "0.7.2"
version: "0.7.3"
appVersion: "0.7.3"
kubeVersion: ">= 1.10.0-0"
home: https://github.com/NVIDIA/k8s-device-plugin
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
# See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
priorityClassName: "system-node-critical"
containers:
- image: nvidia/k8s-device-plugin:v0.7.2
- image: nvidia/k8s-device-plugin:v0.7.3
name: nvidia-device-plugin-ctr
args: ["--fail-on-init-error=false"]
securityContext:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
# See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
priorityClassName: "system-node-critical"
containers:
- image: nvidia/k8s-device-plugin:v0.7.2
- image: nvidia/k8s-device-plugin:v0.7.3
name: nvidia-device-plugin-ctr
args: ["--fail-on-init-error=false", "--pass-device-specs"]
securityContext:
Expand Down
2 changes: 1 addition & 1 deletion nvidia-device-plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
# See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
priorityClassName: "system-node-critical"
containers:
- image: nvidia/k8s-device-plugin:v0.7.2
- image: nvidia/k8s-device-plugin:v0.7.3
name: nvidia-device-plugin-ctr
args: ["--fail-on-init-error=false"]
securityContext:
Expand Down

0 comments on commit e8de9ba

Please sign in to comment.