Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add podLabels/customizable labels to Helm chart #280

Open
sidewinder12s opened this issue Nov 24, 2021 · 5 comments · May be fixed by #690
Open

Add podLabels/customizable labels to Helm chart #280

sidewinder12s opened this issue Nov 24, 2021 · 5 comments · May be fixed by #690
Assignees
@elezar
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@sidewinder12s
Copy link

1. Issue or feature description

Expose a value for setting either podLabels or common labels that are set on the daemonset and pods template.
@sidewinder12s
Copy link
Author

Looks like there might already be a MR for this: https://gitlab.com/nvidia/kubernetes/device-plugin/-/merge_requests/76

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2024
@sidewinder12s
Copy link
Author

Not stale

@elezar elezar self-assigned this Feb 28, 2024
@elezar
Copy link
Member

elezar commented Feb 28, 2024

@sidewinder12s that's fair. Would you be up to create a PR that adds this to the Helm values file?

There was no response on the MR, hence the housekeeping.

@sidewinder12s
Copy link
Author

Let me see, I have to go through my legal team first before we can submit PRs upstream.

@sidewinder12s sidewinder12s linked a pull request May 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elezar elezar

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add podLabels variable for all daemonsets. sidewinder12s/k8s-device-plugin
2 participants
@elezar @sidewinder12s