Add podLabels variable for all daemonsets. #690
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let you add pod labels to the daemonset pods without messing with the selector Labels. Signed-off-by: Geoff Webster <gwebster@aurora.tech>
|
Thanks a lot @sidewinder12s ! |
|
Any update @ArangoGutierrez? |
ArangoGutierrez
approved these changes
May 24, 2024
elezar
reviewed
May 29, 2024
| @@ -38,6 +38,7 @@ spec: | |||
| metadata: | |||
| labels: | |||
| {{- include "nvidia-device-plugin.templateLabels" . | nindent 8 }} | |||
| {{- toYaml .Values.podLabels | nindent 8 }} | |||
There was a problem hiding this comment.
A general question. What is the behaviour if these conflict with any labels generated from templateLabels?
There was a problem hiding this comment.
It should merge and keep the last stated label I believe.
There was a problem hiding this comment.
So if someone passed in a label the templateLabels variable sets, they will override it.
|
Anything else required? |
|
@elezar Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let you add pod labels to the daemonset pods without messing with the selector labels.
Closes #280