Use WithContextDialer to replace WithDialer #472
Conversation
|
close in favor of https://gitlab.com/nvidia/kubernetes/device-plugin/-/merge_requests/345 |
|
@kerthcet please reopen this. We are migrating to GitHub and I will review it here. |
|
/reopen |
| //nolint:staticcheck | ||
| grpc.WithDialer(func(addr string, timeout time.Duration) (net.Conn, error) { | ||
| return net.DialTimeout("unix", addr, timeout) | ||
| grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) { |
There was a problem hiding this comment.
One question I have: How does the change in default TCP timeout as described in https://pkg.go.dev/google.golang.org/grpc#WithContextDialer
Note: All supported releases of Go (as of December 2023) override the OS defaults for TCP keepalive time and interval to 15s. To enable TCP keepalive with OS defaults for keepalive time and interval, use a net.Dialer that sets the KeepAlive field to a negative value, and sets the SO_KEEPALIVE socket option to true from the Control field. For a concrete example of how to do this, see internal.NetDialerWithTCPKeepalive().
affect this change here?
There was a problem hiding this comment.
I think they're different, one is for detecting network liveness, another is for waiting for the network connection. WithDialer also uses WithContextDialer underlying.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Cleanup for TODO.