[Refactor] Simplify UnmarshalJSON with Dedicated Handlers #695
+72
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klueska PTAL |
|
Upon reviewing, I identified a bug in the previous submission that resulted in the failure of two existing unit test functions. To address this, I've removed the switch statement, which was causing the issue. Here are the current unit test results: (base) ➜ v1 git:(main) ✗ go test ./...
ok github.com/NVIDIA/k8s-device-plugin/api/config/v1 0.634s |
haitwang-cloud
changed the title
|
Ping @klueska |
|
Ping @elezar |
Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>
Signed-off-by: haitwang-cloud <haitao_wht@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
UnmarshalJSONmethod forReplicatedDevicesto improve code clarity and structure. Key changes include:Modularization: Created separate handlers (
handleStringInput,handleNumericInput,handleListInput) for different input types, enhancing readability and simplifying future maintenance.Robust Error Handling: Enhanced the error handling in
handleListInputto allow processing of list elements independently.Code Refactoring: Eliminated redundancy by centralizing error checking logic.
Generics Readiness: Prepared
handleNumericInputfor future adaptation to Go's generics (once available).