Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gh-pages] remove build-index.sh #698

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

ArangoGutierrez
Copy link
Collaborator

This patch removes the build-index.sh script
Also adds documentation on how to use the new script at main to update the Helm charts and index.

@ArangoGutierrez ArangoGutierrez self-assigned this May 7, 2024
@ArangoGutierrez
Copy link
Collaborator Author

depends on #691

README.md Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator Author

Now that #691 is in, we can revisit this one

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the instructions following the merged changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator Author

PING @elezar , ready for a next round of reviews

This patch removes the build-index.sh script
Also adds documentation on how to use the new script at `main` to update
the Helm charts and index.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in the deployment folder should not be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants