Allow /dev/shm size to be specified #699
Open
+51
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <elezar@nvidia.com>
klueska
reviewed
May 8, 2024
Comment on lines
+37
to
+45
| c := cli.Command{ | ||
| Name: "mount-shm", | ||
| Usage: "Set up the /dev/shm mount required by the MPS daemon", | ||
| Before: func(ctx *cli.Context) error { | ||
| return validateFlags(ctx, &opts) | ||
| }, | ||
| Action: func(ctx *cli.Context) error { | ||
| return mountShm(ctx, &opts) | ||
| }, |
There was a problem hiding this comment.
I has assumed we would do this as a configuration parameter in the config file
There was a problem hiding this comment.
Yes, I had that in mind too and was looking into that as a follow up to this commit.
Would you ONLY expose it in the config file?
There was a problem hiding this comment.
I think we definitely want it in the config -- I don't have a strong opinion about whether it is also a command line flag. Probably not though, since other MPS options aren't.
klueska
requested changes
May 24, 2024
Comment on lines
+37
to
+45
| c := cli.Command{ | ||
| Name: "mount-shm", | ||
| Usage: "Set up the /dev/shm mount required by the MPS daemon", | ||
| Before: func(ctx *cli.Context) error { | ||
| return validateFlags(ctx, &opts) | ||
| }, | ||
| Action: func(ctx *cli.Context) error { | ||
| return mountShm(ctx, &opts) | ||
| }, |
There was a problem hiding this comment.
I think we definitely want it in the config -- I don't have a strong opinion about whether it is also a command line flag. Probably not though, since other MPS options aren't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the size of the /dev/shm created for MPS to be specified as part of the helm deployment.