Accept kubelet socket from command line #790
Open
+36
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
accept-kubelet-socket-from-command-line
branch
from
464141f
to
7e7c85d
Compare
tariq1890
reviewed
Jun 28, 2024
This change accepts the kubelet socket as a command line argument. If an empty string is specified, registration with the kubelet is skipped. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
accept-kubelet-socket-from-command-line
branch
from
7e7c85d
to
b2d260f
Compare
tariq1890
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes it possible to test device plugin logic that does not depend on the kubelet.