Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning when set memory limits check is pre-volta arch #797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add warning when set memory limits check is pre-volta arch #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/mps-control-daemon/mps/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ func (m *Daemon) perDevicePinnedDeviceMemoryLimits() map[string]string {
totalMemoryInBytesPerDevice := make(map[string]uint64)
replicasPerDevice := make(map[string]uint64)
for _, device := range m.Devices() {
if isVoltaDevice := (*mpsDevice)(device).isAtLeastVolta(); !isVoltaDevice {
klog.Warningf("Device uuid %s is pre-volta arch, canno't set memory limits.", device.ID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
klog.Warningf("Device uuid %s is pre-volta arch, canno't set memory limits.", device.ID)
klog.Warningf("Skipping memory limits for pre-volta device %s", device.ID)

continue
}
index := device.Index
totalMemoryInBytesPerDevice[index] = device.TotalMemory
replicasPerDevice[index] += 1
Expand Down