Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align image builds with other projects #14

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

elezar
Copy link
Member

@elezar elezar commented Apr 11, 2024

These changes align the Makefile and image builds with other projects.

This will allow images to be properly generated using GitHub actions.

@elezar elezar self-assigned this Apr 11, 2024
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a nit/question

deployments/container/Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@@ -0,0 +1,19 @@
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

@@ -0,0 +1,31 @@
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

Copy link
Collaborator

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested a review from ArangoGutierrez April 18, 2024 08:38
@elezar elezar merged commit 000ad9c into NVIDIA:main Apr 18, 2024
5 checks passed
@elezar elezar deleted the build-images branch April 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants