Start serving the plugin API prior to registering with kubelet #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the recommended order when starting a plugin. Additionally, not starting the server prior to registration causes issues starting with K8s 1.25. It is unclear exactly what changed in 1.25 that brings this issue to surface, but it is possible kubelet now implicitly assumes a plugin is starting to serve the API upon receiving a registration request. Without this change, we see the following kubelet logs: "Got registration request from device plugin with resource" resourceName="nvidia.com/***" "Unable to connect to device plugin client with socket path" err="failed to dial device plugin: context deadline exceeded" path="/var/lib/kubelet/device-plugins/kubevirt-***.sock" Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
rthallisey
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the recommended order when starting a plugin. Additionally, not starting the server prior to registration causes issues starting with K8s 1.25. It is unclear exactly what changed in 1.25 that brings this issue to surface, but it is possible kubelet now implicitly assumes a plugin is starting to serve the API upon receiving a registration request.
Without this change, we see the following kubelet logs:
Signed-off-by: Christopher Desiniotis cdesiniotis@nvidia.com