-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors due to mismatch of GLIBC version caused from Go 1.20+ #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the binary is built with glibc version different than the target image. This is happening since Go version is updated with commit: 24751ab. To avoid this, we are installing Go with the same base image as the target one. Errors: kubevirt-gpu-device-plugin: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by kubevirt-gpu-device-plugin) kubevirt-gpu-device-plugin: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by kubevirt-gpu-device-plugin) Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
shivamerla
changed the title
Fix errors due to mismatch of GLIBC version caused from Go 1.20+ when…
Fix errors due to mismatch of GLIBC version caused from Go 1.20+
Nov 7, 2023
Tested with vGPU devices
|
Thanks @shivamerla. We are avoiding the potential glibc version mismatch by installing go + building go binaries in the target base image (in this case the CUDA base image). This aligns with how we build our other containers. For example, k8s-device-plugin: https://gitlab.com/nvidia/kubernetes/device-plugin/-/blob/main/deployments/container/Dockerfile.ubi8 cc @rthallisey |
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors due to mismatch of GLIBC version caused from Go 1.20+ when the binary is built with glibc version different than the target image. This is happening since Go version is updated with commit: 24751ab. To avoid this, we are installing Go with the same base image as the target one.
Errors: