Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dropout from decoder cell state #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardburleigh
Copy link

Fix FP16 stagnation at "OVERFLOW! Skipping step. Attempted loss scale.."

Fix FP16 stagnation at "OVERFLOW! Skipping step. Attempted loss scale.."
@thepowerfuldeez
Copy link

Thank you! That helped me

@candlewill
Copy link

but why?

@mychiux413
Copy link

It helped me, too.
And I noticed that the tacotron2 only apply dropout on hidden state.

After several studies,
there seems to be no consensus on how to dropout RNN,
and many papers discussed this.

Here is my opinion:
The intuition of dropout is: "Can't rely on any one feature, so have to spread out weight.",
so if we apply dropout on hidden state,
which means we don't want those gates only depend on some specific input features.

But the cell states run directly along the entire chain of RNN, to achieve the long memory behavior. Therefore, if we drop the cell state weights for each recurrent, this seems to mean that we do not want the memory to pass too long?

@Jeevesh8
Copy link
Contributor

@mychiux413 But how would that lead to gradient overflow ?

@chazo1994
Copy link

It helped me, too. And I noticed that the tacotron2 only apply dropout on hidden state.

After several studies, there seems to be no consensus on how to dropout RNN, and many papers discussed this.

Here is my opinion: The intuition of dropout is: "Can't rely on any one feature, so have to spread out weight.", so if we apply dropout on hidden state, which means we don't want those gates only depend on some specific input features.

But the cell states run directly along the entire chain of RNN, to achieve the long memory behavior. Therefore, if we drop the cell state weights for each recurrent, this seems to mean that we do not want the memory to pass too long?

@mychiux413 But how about the quality of fp32 model after change the code like this commit ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants