Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue when no scaler is given, but it is present in the checkpoint #111

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

cfd1
Copy link
Contributor

@cfd1 cfd1 commented Sep 23, 2023

Modulus Pull Request

Description

Fixes an issue when no scaler is given, but it is present in the checkpoint.
Mentioned in issue #83

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is
    up to date with these changes.

Dependencies

N/A

@cfd1
Copy link
Contributor Author

cfd1 commented Sep 23, 2023

I don't believe the documentation requires updating as it is a bugfix.

@mnabian mnabian self-requested a review September 25, 2023 20:31
@mnabian mnabian added bug Something isn't working 5 - Ready to Merge Testing and reviews complete, ready to merge labels Sep 25, 2023
@mnabian
Copy link
Collaborator

mnabian commented Sep 25, 2023

/blossom-ci

@mnabian mnabian merged commit 97c8e20 into NVIDIA:main Sep 25, 2023
@mnabian
Copy link
Collaborator

mnabian commented Sep 25, 2023

@cfd1 your change looks good to me. Thanks for contributing to Modulus!

@NickGeneva NickGeneva added the external Issues/PR filed by people outside the team label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working external Issues/PR filed by people outside the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants