Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide schemas to createDataFrame for backwards compatibility #816

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

rishic3
Copy link
Collaborator

@rishic3 rishic3 commented Jan 2, 2025

Numpy support for createDataFrame was introduced in PySpark 3.4.0; previous versions require PDF with schema.
This resolves #815 . Tested against PySpark 3.2.1.

Signed-off-by: Rishi Chandra <rishic@nvidia.com>
@rishic3
Copy link
Collaborator Author

rishic3 commented Jan 2, 2025

build

@rishic3 rishic3 marked this pull request as ready for review January 2, 2025 16:04
Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to have array valued column for dense case vs multiple scale columns, but ok for now.

@eordentlich eordentlich merged commit 0b68de4 into NVIDIA:branch-24.12 Jan 2, 2025
3 checks passed
@rishic3 rishic3 deleted the umap_test_error branch January 2, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Nightly tests/test_umap.py::test_umap_model_persistence[False] FAILED
2 participants