Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Disable grouping applications by name #1099

Closed
Tracked by #1221
amahussein opened this issue Jun 10, 2024 · 0 comments · Fixed by #1230
Closed
Tracked by #1221

[FEA] Disable grouping applications by name #1099

amahussein opened this issue Jun 10, 2024 · 0 comments · Fixed by #1230
Assignees
@amahussein
Labels
affect-output A change that modifies the output (add/remove/rename files, add/remove/rename columns) feature request New feature or request usability track issues related to the Tools's user experience user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@amahussein
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

In the CLI, the qualification_summary.csv lists rows by grouping applications with same names together.
We need to disable this feature by default and leave it to the users to group the results the way that fit their needs.
Users on Databricks have all apps with the same name which turn out to be a confusing feature rather than a helpful one.
@amahussein amahussein added feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python) ? - Needs Triage usability track issues related to the Tools's user experience labels Jun 10, 2024
@amahussein amahussein self-assigned this Jun 11, 2024
@amahussein amahussein removed their assignment Jun 12, 2024
@amahussein amahussein self-assigned this Jul 1, 2024
@parthosa parthosa mentioned this issue Jul 23, 2024
Merged
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Jul 25, 2024
@amahussein
remove gpu-cluster-reshape and grouping of apps
d3b76e8 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#1099

- disable grouping of results by row_name
- the file `qualification_summary_full.csv` is omitted
This was referenced Jul 25, 2024
Merged
Open
@amahussein amahussein added the affect-output A change that modifies the output (add/remove/rename files, add/remove/rename columns) label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
affect-output A change that modifies the output (add/remove/rename files, add/remove/rename columns) feature request New feature or request usability track issues related to the Tools's user experience user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove arguments related to cost-savings amahussein/spark-rapids-tools
1 participant
@amahussein