Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Remove arguments related to cost-savings #1229

Closed
Tracked by #1221
amahussein opened this issue Jul 25, 2024 · 0 comments · Fixed by #1230
Closed
Tracked by #1221

[TASK] Remove arguments related to cost-savings #1229

amahussein opened this issue Jul 25, 2024 · 0 comments · Fixed by #1230
Assignees
@amahussein
Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@amahussein
Copy link
Collaborator

amahussein commented Jul 25, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

In order to turn-off cost savings, we need to remove all the arguments related to costs savings because it will cause bugs

The following arguments in rapids_tools qualification cmd:

  • estimation_model: str = None, (because xgboost is the only option)
  • cpu_cluster_price: float = None,
  • estimated_gpu_cluster_price: float = None,
  • cpu_discount: int = None,
  • gpu_discount: int = None,
  • global_discount: int = None,
  • gpu_cluster_recommendation

In addition, we need to remove the legacy CLI cmds spark_rapids_user_tools
@amahussein amahussein added user_tools Scope the wrapper module running CSP, QualX, and reports (python) ? - Needs Triage labels Jul 25, 2024
@amahussein amahussein self-assigned this Jul 25, 2024
@amahussein amahussein mentioned this issue Jul 25, 2024
Open
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Jul 25, 2024
@amahussein
Remove arguments related to cost-savings
d5441c6 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#1229

- remove the legacy `spark_rapids_user_tools` cmd
- remove qualification arguments related to cost-savings
@amahussein amahussein mentioned this issue Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove arguments related to cost-savings amahussein/spark-rapids-tools
1 participant
@amahussein