Skip to content

Commit

Permalink
Do not package the Databricks 14.3 shim into the dist jar
Browse files Browse the repository at this point in the history
The 350db143 shim will be packaged into the dist jar in branch-25.02

Signed-off-by: timl <timl@nvidia.com>
  • Loading branch information
NvTimLiu committed Nov 21, 2024
1 parent 20c5281 commit 676c7c5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion build/get_buildvers.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _get_buildvers(buildvers, pom_file, logger=None):
else:
no_snapshots.append(release)
excluded_shims = pom.find(".//pom:dyn.shim.excluded.releases", ns)
if excluded_shims:
if excluded_shims is not None:
for removed_shim in [x.strip() for x in excluded_shims.text.split(",")]:
if removed_shim in snapshots:
snapshots.remove(removed_shim)
Expand Down
3 changes: 2 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,8 @@

<properties>
<!-- start dyn.shim properties -->
<dyn.shim.excluded.releases/>
<!-- TODO: will package 350db143 shim into the dist jar in branch-25.02 -->
<dyn.shim.excluded.releases>350db143</dyn.shim.excluded.releases>
<!-- end dyn.shim properties -->

<rapids.module>.</rapids.module>
Expand Down
3 changes: 2 additions & 1 deletion scala2.13/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,8 @@

<properties>
<!-- start dyn.shim properties -->
<dyn.shim.excluded.releases/>
<!-- TODO: will package 350db143 shim into the dist jar in branch-25.02 -->
<dyn.shim.excluded.releases>350db143</dyn.shim.excluded.releases>
<!-- end dyn.shim properties -->

<rapids.module>.</rapids.module>
Expand Down

0 comments on commit 676c7c5

Please sign in to comment.