-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Clean up unused and duplicated 'org/roaringbitmap' folder in the spark3xx shims #11175
Labels
bug
Something isn't working
Comments
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this issue
Jul 12, 2024
To fix: NVIDIA#11175 Clean up unused and duplicated 'org/roaringbitmap' folders in the spark3xx shims Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this issue
Jul 12, 2024
To fix: NVIDIA#11175 Clean up unused and duplicated 'org/roaringbitmap' in the spark320 shim folder to work around for the JACOCO error 'different class with same name', after we drop 31x shims and change the default shim to spark320 Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this issue
Jul 12, 2024
To fix: NVIDIA#11175 Clean up unused and duplicated 'org/roaringbitmap' in the spark320 shim folder to walk around for the JACOCO error 'different class with same name', after we drop 31x shims and change the default shim to spark320 Signed-off-by: Tim Liu <timl@nvidia.com>
cc @liurenjie1024 to help thanks |
This looks like the first occurrence of a multi-release jar among our dependencies. binary-dedupe.sh does not handle it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Should clean up unused and duplicated 'spark3xx/META-INF/versions/11/org/roaringbitmap/' folder in the spark3xx shims,
we've had the same in ./spark-shared/com/nvidia/shaded/spark/org/roaringbitmap/ folder in the dist jar
Besides, the duplicated files in
roaringbitmap/
will cause errors like jacocodifferent class with same name
:https://github.com/NVIDIA/spark-rapids/blob/branch-24.08/jenkins/Jenkinsfile-blossom.premerge#L196-L200
The text was updated successfully, but these errors were encountered: