Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] dist jar does not contain reduced pom, creates an unnecessary jar #5557

Closed
gerashegalov opened this issue May 20, 2022 · 0 comments · Fixed by #5558
Closed

[BUG] dist jar does not contain reduced pom, creates an unnecessary jar #5557

gerashegalov opened this issue May 20, 2022 · 0 comments · Fixed by #5558
Assignees
@gerashegalov
Labels
bug Something isn't working build Related to CI / CD or cleanly building P0 Must have for release
Milestone
May 2 - May 20

Comments

@gerashegalov
Copy link
Collaborator

Describe the bug
After we introduced a cuda classifier for the dist artifact, we forgot to change the code that updates the jar with the reduced pom because the target of the update was not updated with the classifier.

Moreover it results in the creation of a quasi-empty non-functional rapids-4-spark_2.12-22.06.0-SNAPSHOT.jar

     0 Thu May 19 16:26:46 PDT 2022 META-INF/
     0 Thu May 19 16:26:46 PDT 2022 META-INF/maven/
     0 Thu May 19 16:26:46 PDT 2022 META-INF/maven/com.nvidia/
     0 Thu May 19 16:26:46 PDT 2022 META-INF/maven/com.nvidia/rapids-4-spark_2.12/
     0 Thu May 19 16:26:30 PDT 2022 META-INF/services/
 18541 Thu May 19 18:10:26 PDT 2022 META-INF/maven/com.nvidia/rapids-4-spark_2.12/pom.xml
    64 Thu May 19 18:10:22 PDT 2022 META-INF/services/com.nvidia.spark.rapids.SparkShimServiceProvider
   202 Thu May 19 18:10:10 PDT 2022 rapids4spark-version-info.properties

that may confuse the user to create doomed-to-fail deployments.

Steps/Code to reproduce bug

 ./build/buildall --clean --profile=311,321 --module=integration_tests

Expected behavior
Build should emit a single artifact with the updated pom
rapids-4-spark_<scala.version>-<rapids.version>-cudaXY.jar

Environment details (please complete the following information)

  • Environment location: anywhere
  • Spark configuration settings related to the issue: NA

Additional context
#5249
@gerashegalov gerashegalov added bug Something isn't working build Related to CI / CD or cleanly building P0 Must have for release labels May 20, 2022
@gerashegalov gerashegalov added this to the May 2 - May 20 milestone May 20, 2022
@gerashegalov gerashegalov self-assigned this May 20, 2022
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue May 20, 2022
@gerashegalov
Fix target file for update from extra-resources
1059f1b 
Closes NVIDIA#5557

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov mentioned this issue May 20, 2022
Merged
gerashegalov added a commit that referenced this issue May 20, 2022
@gerashegalov
Fix target file for update from extra-resources (#5558)
7471df5 
This PR fixes the target artifact file name for the update with extra-resources.

Closes #5557.

Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working build Related to CI / CD or cleanly building P0 Must have for release
Projects
None yet
Milestone
May 2 - May 20
Development

Successfully merging a pull request may close this issue.

Fix target file for update from extra-resources in dist module gerashegalov/spark-rapids
1 participant
@gerashegalov