-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Inconsistency between the time zone in the fallback reason and the actual time zone checked in RapidsMeta.checkTImeZoneId #5678
Comments
Shall we require both of session time zone id and the JVM time zone id to be "UTC" ? |
+1 It was my vote too on the internal thread. |
Thanks for the information. Do we have a deal now ? |
Feel free to propose a PR @firestarman |
@gerashegalov Here is the fix #5767, could you help review ? |
There are two settings for time zone, the Spark session local time zone and JVM's default time zone. And they may be different from each other according to issue #5678. With this PR, plugin now requires both of the two settings being equal to UTC to support timestamp type. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Describe the bug
RapidsMeta.checkTImeZoneId
compares the default time zone of the JVM to UTC in order to fallback on CPU, but quotes the session time zone as the offending actualSteps/Code to reproduce bug
GMT-8
:And observe a confusing message
Only UTC zone id is supported. Actual zone id: UTC
Expected behavior
A clear actionable message after determining if we can support non-UTC session time zone provided that the JVM time zone is the supported UTC
Environment details (please complete the following information)
Additional context
rapidsai/cudf#2477
h/t @viadea
The text was updated successfully, but these errors were encountered: