Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add tests for .count() in the file readers #717

Closed
tgravescs opened this issue Sep 10, 2020 · 0 comments · Fixed by #6055
Closed

[FEA] Add tests for .count() in the file readers #717

tgravescs opened this issue Sep 10, 2020 · 0 comments · Fixed by #6055
Labels
good first issue Good for newcomers P1 Nice to have for release test Only impacts tests

Comments

@tgravescs
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
we should add more tests in the file readers (parquet, orc, csv) that do a .count(). This generally takes a separate path then reading the full data because it just passes along the row counts and not the data itself.
I didn't see any of these tests in the integration suite so we shoul dadd some
@tgravescs tgravescs added feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 10, 2020
@sameerz sameerz added P1 Nice to have for release test Only impacts tests and removed ? - Needs Triage Need team to review and classify feature request New feature or request labels Sep 15, 2020
@sameerz sameerz added the good first issue Good for newcomers label Dec 3, 2020
@thirtiseven thirtiseven mentioned this issue Jul 22, 2022
Merged
@sameerz sameerz mentioned this issue Aug 2, 2022
Closed
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@pxLi
Enable automerge 22.12 to 23.02 (NVIDIA#717)
8b1b8d3 
Signed-off-by: Peixin Li <pxli@nyu.edu>

Signed-off-by: Peixin Li <pxli@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers P1 Nice to have for release test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for .count() in the file readers thirtiseven/spark-rapids
3 participants
@tgravescs @sameerz @thirtiseven