Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GetJsonObject by default and add tests for as many issues with it as possible #10220

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jan 18, 2024

this fixes #10197 and adds tests for a large number of other issues.

…h it as possible

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
docs/compatibility.md Outdated Show resolved Hide resolved
integration_tests/src/main/python/get_json_test.py Outdated Show resolved Hide resolved
@revans2
Copy link
Collaborator Author

revans2 commented Jan 19, 2024

build

@sameerz
Copy link
Collaborator

sameerz commented Jan 22, 2024

build

@revans2
Copy link
Collaborator Author

revans2 commented Jan 22, 2024

This has crashed the precommit build twice with the same error about the integration tests crashing. I need to do dig some more before we try and build again.

@revans2
Copy link
Collaborator Author

revans2 commented Jan 22, 2024

Never mind it is the bind error for the UI again.

#10227

@revans2
Copy link
Collaborator Author

revans2 commented Jan 22, 2024

build

@revans2 revans2 merged commit 02f5c7b into NVIDIA:branch-24.02 Jan 22, 2024
40 checks passed
@revans2 revans2 deleted the disable_get_json_object branch January 22, 2024 18:44
@sameerz sameerz added the test Only impacts tests label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Disable GetJsonObject by default and update docs
3 participants