More compilation fixes for Spark 4.0.0 [databricks] #10978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
mythrocks
previously approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM, so far.
Here's the latest build break:
[INFO] Compiling 421 Scala sources and 59 Java sources to /home/runner/work/spark-rapids/spark-rapids/sql-plugin/target/spark312/classes ...
Error: ] /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/java/com/nvidia/spark/rapids/CudfUnsafeRow.java:31: cannot find symbol
symbol: class VariantVal
location: package org.apache.spark.unsafe.types
Error: ] /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/java/com/nvidia/spark/rapids/CudfUnsafeRow.java:404: cannot find symbol
symbol: class VariantVal
location: class com.nvidia.spark.rapids.CudfUnsafeRow
Error: ] /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/java/com/nvidia/spark/rapids/CudfUnsafeRow.java:403: method does not override or implement a method from a supertype
|
Sorry, this should be shimmed! |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
gerashegalov
as code owners
This reverts commit dc4823b.
|
build |
|
Reviewing the latest version now. |
mythrocks
approved these changes
Jun 5, 2024
SurajAralihalli
pushed a commit
to SurajAralihalli/spark-rapids
that referenced
this pull request
Jul 12, 2024
* More compilation fixes * Signing off Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Added shim for UnsafeCudfRow * POM changes Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Added shim for UnsafeCudfRow * Revert "POM changes" This reverts commit dc4823b. --------- Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the last bit of the compilation errors, when building for Spark 4.0.
fixes #10972