Allow more expressions to be tiered [databricks] #11179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
|
build |
|
permerge failed with #8418 |
|
build |
jlowe
reviewed
Jul 12, 2024
Comment on lines
167
to
169
| // We don't strip off the first condition expression because it is the only one | ||
| // that is guaranteed to be executed. | ||
| c.branches.map(_._1) |
There was a problem hiding this comment.
The case above only looks at the very first expression of the first branch, but this grabs the predicate expression of all branches. These are not guaranteed to be executed when there's side effects, as it will short-circuit sometimes in such a way that some of the branch predicates will never be evaluated. Sort of like the GpuIf case, don't we want to be examining whether the branch predicate expressions have side effects?
Comment mentions "the first condition expression" but this grabs all conditional expressions which is confusing.
|
@jlowe I updated the comments please take another look. |
|
build |
jlowe
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of some work I am doing to be able to combine multiple expressions together into a single kernel. But this was large enough that I thought I should do it separately.
Essentially this comes down to that we are being very conservative in doing tiered projects. We assume that all expressions could throw an exception so we have to have rules that deal with conditional expressions so we don't accidentally rewrite something like
if(never going to happen, throw an error, it is all good)to alwaysthrow an error. But we have ahasSideEffectsmethod on allGpuExpressions, which is used in the conditionals code to avoid these same situations. This updates the tiered expression code to only be conservative in cases where it is warranted.