Use the new chunked API from multi-get_json_object #11289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
jlowe
approved these changes
Aug 5, 2024
gerashegalov
approved these changes
Aug 5, 2024
| validPathsIndex += 1 | ||
| } | ||
| withResource(JSONUtils.getJsonObjectMultiplePaths(input.getBase, | ||
| java.util.Arrays.asList(validPaths: _*), 4 * targetBatchSize, |
There was a problem hiding this comment.
the comment about memory budget is being removed. Consider re-adding or making 4 a mnemonic constant.
| validPathsIndex += 1 | ||
| } | ||
| withResource(JSONUtils.getJsonObjectMultiplePaths(input.getBase, | ||
| java.util.Arrays.asList(validPaths: _*), 4 * targetBatchSize, |
There was a problem hiding this comment.
nit:
throughout this file constructs like java.util.Arrays.asList(validPaths: _*)
can be replaced with validPaths.asJava
if we import scala.collection.JavaConverters._
sameerz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on NVIDIA/spark-rapids-jni#2299
and technically fixes #11263
I think there is more that we could do to make it even better, but I think this is good enough in the short term.
The performance improvement appears to be about 9% for large numbers of paths. I want to spend some more time testing on other GPUs though.