Make hive column matches not case-sensitive #11327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
razajafri
reviewed
Aug 14, 2024
| val distinctFields = distinctColumns.map(a => tableSchema.apply(a.name)) | ||
| // In hive column names are case-insensitive but the default tableSchema lookup is | ||
| // case-sensitive | ||
| val fieldMap = CaseInsensitiveMap(tableSchema.map(f => (f.name, f)).toMap) |
There was a problem hiding this comment.
What happens when spark.sql.caseSensitive is set to true?
There was a problem hiding this comment.
Turns out that Hive is always case-insensitive So even if I try to create a table with two columns with different case I get an error from hive.
scala> spark.conf.set("spark.sql.caseSensitive", true)
scala> spark.sql("""create table testcase_text(id int, nAme string, Name string)""").collect
24/08/15 15:38:30 WARN ResolveSessionCatalog: A Hive serde table will be created as there is no table provider specified. You can set spark.sql.legacy.createHiveTableByDefault to false so that native data source table will be created instead.
org.apache.spark.sql.AnalysisException: org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.hadoop.hive.ql.metadata.HiveException: Duplicate column name name in the table definition.
at org.apache.spark.sql.hive.HiveExternalCatalog.withClient(HiveExternalCatalog.scala:110)
at org.apache.spark.sql.hive.HiveExternalCatalog.createTable(HiveExternalCatalog.scala:244)
at org.apache.spark.sql.catalyst.catalog.ExternalCatalogWithListener.createTable(ExternalCatalogWithListener.scala:94)
If I try to put in a name with the wrong case in the query when case sensitive is true, then spark outputs an error in the logical plan phase before the GPU code ever runs.
jlowe
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11318
I added in two tests. The partitioning test passes without these changes, but I wanted to be sure that we were doing the right thing.
I didn't add tests for Spark when it is made case sensitive because
spark.sql.caseSensitive = truebecause it fails when spark goes to plan it both on the CPU and the GPU before the GPU code ever runs. But I can add tests for that if we really want to verify that.