-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set numRows for the ColumnBatch created in GpuBringBackToHost #11365
Conversation
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuBringBackToHost.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Jihoon Son <ghoonson@gmail.com>
build |
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuBringBackToHost.scala
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/GpuBringBackToHostSuite.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCoalesceBatches.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but a quick grep of the source shows there's some other cases where this is done incorrectly, e.g.:
- TestingV2Source
- CurrentBatchIterator
- GpuBroadcastNestedLoopJoinExecBase (empty batch, probably OK)
- GpuPartitionerExpr
- GpuBloomFilterMightContain (empty batch, probably OK)
- ImplicitTestsSuite
- RapidsShuffleTestHelper
If not handling here, we should track these for followup.
@jlowe I did have checked all other places except for those in the unit test assuming they are fine. AFAIT, those places in production that use the constructor without the row count have two patterns.
I think the real issue here is that the |
build |
Fixes #11364.