-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spark400 build in datagen and tests #11375
Conversation
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
build |
the change would fail shims other than 400 like spark320,
|
Weird, the github workflow matrix builds for 320 passed, so wonder how the blossom CI failed to build. I also tested this locally before pushing the changes, and it compiled for spark320 and passed the test that is somehow failing to build in blossom CI. |
The CI failure is due to a bug where CI ends up downloading nightly snapshot artifacts to test against rather than the artifacts built from the PR premerge build. See #11382. |
build |
Fixes #11372. Adds expression shims for code that's trying to build Column from expressions or extract an expression from a Column. Also unshims and removes an unnecessary base class that no longer needs to be shimmed.