Fix nightly snapshots being downloaded in premerge build #11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
requested review from
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
gerashegalov
as code owners
|
build |
razajafri
approved these changes
Aug 22, 2024
|
@revans2 @tgravescs can you guys take a look please |
tgravescs
approved these changes
Aug 22, 2024
revans2
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
But I am no expert on this and would love to get some feedback from others more knowledgeable like @gerashegalov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11382. Uses
mvn packageinstead ofmvn testin the premerge build script when performing test runs when amvn installwas not guaranteed to be run prior.