Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log DBR BuildInfo [databricks] #11455

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Log DBR BuildInfo [databricks] #11455

merged 6 commits into from
Sep 10, 2024

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Sep 10, 2024 •
edited
Loading

Fixes #8587

  • Match the dbrVersion from the binaries
  • Log the build info exposed in current_version
  • Fix the WITH_BLOOP build
2024-09-10 16:21:42,019 [Thread-6] WARN  com.nvidia.spark.rapids.DatabricksShimServiceProvider - Databricks Runtime Build Info match: SUCCESS
        DBR_VERSION: 11.3.x-snapshot-gpu-ml-scala2.12
        spark.BuildInfo.gitHash: d65fb2374451fd10bf416297dc22549bcbaf2702
        databricks.BuildInfo.gitHash: b7fd9d058866e0f98f78304bf90c690198e2b208
        databricks.BuildInfo.gitTimestamp: 20240820204043

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Log DBR BuildInfo
15e1271 
Fixes NVIDIA#8587

- Match Version from the binaries
- Log build info exposed in current_version

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
tab
53f25cf 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
330db fix
f7561e6 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov added the task Work required that improves the product but is not user facing label Sep 10, 2024
@gerashegalov gerashegalov self-assigned this Sep 10, 2024
@gerashegalov
Copy link
Collaborator Author

build

jlowe
jlowe reviewed Sep 10, 2024
View reviewed changes
...plugin/src/main/spark330db/scala/com/nvidia/spark/rapids/DatabricksShimServiceProvider.scala Outdated Show resolved Hide resolved
...plugin/src/main/spark330db/scala/com/nvidia/spark/rapids/DatabricksShimServiceProvider.scala Outdated Show resolved Hide resolved
...plugin/src/main/spark330db/scala/com/nvidia/spark/rapids/DatabricksShimServiceProvider.scala Outdated Show resolved Hide resolved
...ain/spark330db/scala/com/nvidia/spark/rapids/shims/spark330db/SparkShimServiceProvider.scala Outdated Show resolved Hide resolved
...ain/spark332db/scala/com/nvidia/spark/rapids/shims/spark332db/SparkShimServiceProvider.scala Outdated Show resolved Hide resolved
...ain/spark341db/scala/com/nvidia/spark/rapids/shims/spark341db/SparkShimServiceProvider.scala Outdated Show resolved Hide resolved
gerashegalov and others added 3 commits September 10, 2024 08:02
@gerashegalov @jlowe
Update sql-plugin/src/main/spark330db/scala/com/nvidia/spark/rapids/D…
a1a128f 
…atabricksShimServiceProvider.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@gerashegalov
review
e55dcc0 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Review
515f751 
and adding gitTimestamp

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit a92bfbf into NVIDIA:branch-24.10 Sep 10, 2024
44 of 45 checks passed
@gerashegalov gerashegalov deleted the dbrShimMatch branch September 10, 2024 20:03
@abellina abellina mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

Assignees

@gerashegalov gerashegalov

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Databricks runtime shim detection
2 participants
@gerashegalov @jlowe