Use UnaryLike instead of UnaryExpression [databricks] #11490
Merged
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
abellina
changed the title
revans2
approved these changes
Sep 23, 2024
|
build |
gerashegalov
approved these changes
Sep 23, 2024
abellina
changed the title
|
build |
|
@gerashegalov good point, thanks! running them now. |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11479
This is a potential solution to #11479, where in Spark 4.0.0,
Randwas changed to not subclass fromUnaryExpressionand instead it subclassesUnaryLike[Expression](apache/spark#48004).This required changing some of Cast as well since it also used
UnaryExpressiondirectly.Draft to run all of CI and gather reviews on the approach.