Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSON scan and from_json #11702

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Improve JSON scan and from_json #11702

merged 8 commits into from
Nov 14, 2024

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Nov 6, 2024 •
edited
Loading

This implements a few improvements for JSON scan and from_json:

  • For both JSON scan and from_json: support disabling allowSingleQuotes option.
  • For from_json with map<string, string> schema:
    • Add the ability to pass down options for turning on/off allowSingleQuotes, allowNumericLeadingZeros, allowNonNumericNumbers, and allowUnquotedControlChars, along with the corresponding tests.
    • Add more tests.

Depends on:

@ttnghia
Add test
a954063 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Merge branch 'branch-24.12' into add_test_from_json
b1e22cb
@ttnghia ttnghia added the test Only impacts tests label Nov 6, 2024
@ttnghia ttnghia requested a review from revans2 November 6, 2024 22:32
@ttnghia ttnghia self-assigned this Nov 6, 2024
@ttnghia ttnghia marked this pull request as draft November 6, 2024 22:48
@ttnghia
Add test test_from_json_map_with_options
8ce1817 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia ttnghia changed the title Add integration test for from_json with map<string, string> schema Improve from_json with map<string, string> schema Nov 6, 2024
@ttnghia
Pass down JSON options to JNI
35f66db 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Add support for allowSingleQuotes==false
e78fb32 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia ttnghia changed the title Improve from_json with map<string, string> schema Improve JSON scan and from_json with map<string, string> schema Nov 7, 2024
@ttnghia ttnghia changed the title Improve JSON scan and from_json with map<string, string> schema Improve JSON scan and from_json Nov 7, 2024
@ttnghia
Fix tests
15a4113 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia ttnghia force-pushed the add_test_from_json branch from 0b21c8a to 15a4113 Compare November 7, 2024 05:23
revans2
revans2 previously approved these changes Nov 7, 2024
View reviewed changes
@ttnghia
Update test
d746784 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@revans2 revans2 mentioned this pull request Nov 13, 2024
Merged
@ttnghia ttnghia marked this pull request as ready for review November 14, 2024 05:08
@ttnghia
Copy link
Collaborator Author

ttnghia commented Nov 14, 2024

build

@ttnghia ttnghia merged commit a8010cc into NVIDIA:branch-24.12 Nov 14, 2024
48 of 49 checks passed
@ttnghia ttnghia deleted the add_test_from_json branch November 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@ttnghia ttnghia

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttnghia @revans2