Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for regexp() and regexp_like() [databricks] #4093

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Add tests for regexp() and regexp_like() [databricks] #4093

merged 5 commits into from
Dec 2, 2021

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Nov 12, 2021 •
edited
Loading

Signed-off-by: Andy Grove andygrove@nvidia.com

Spark 3.2.0 adds regexp and regexp_like SQL functions which are synonyms for the RLike expression which we already support.

This PR simply adds tests for this.

@andygrove andygrove added documentation Improvements or additions to documentation test Only impacts tests labels Nov 12, 2021
@andygrove andygrove added this to the Nov 1 - Nov 12 milestone Nov 12, 2021
@andygrove andygrove self-assigned this Nov 12, 2021
@andygrove andygrove changed the title Add tests and docs for regexp() and regexp_like() Add tests and docs for regexp() and regexp_like() [databricks] Nov 12, 2021
@andygrove
Copy link
Contributor Author

build

@andygrove andygrove changed the base branch from branch-21.12 to branch-22.02 November 15, 2021 15:01
@andygrove andygrove changed the title Add tests and docs for regexp() and regexp_like() [databricks] Add tests for regexp() and regexp_like() [databricks] Nov 17, 2021
@andygrove
Copy link
Contributor Author

build

@andygrove andygrove requested a review from jlowe November 30, 2021 21:51
jlowe
jlowe previously approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve the conflict but otherwise lgtm.

@andygrove
Copy link
Contributor Author

build

@andygrove
Copy link
Contributor Author

build

@andygrove
Copy link
Contributor Author

build

@andygrove andygrove requested a review from jlowe December 2, 2021 15:31
@andygrove andygrove merged commit 08d295a into NVIDIA:branch-22.02 Dec 2, 2021
@andygrove andygrove deleted the regexp-like branch December 2, 2021 16:03
res-life pushed a commit to res-life/spark-rapids that referenced this pull request Dec 6, 2021
@andygrove
Add tests for regexp() and regexp_like() [databricks] (NVIDIA#4093)
2ad38e6 
* Add tests for regexp and regexplike (synonyms for RLike)

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* add import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@andygrove andygrove

Labels
documentation Improvements or additions to documentation test Only impacts tests
Projects
None yet
Milestone
Nov 30 - Dec 10
Development

Successfully merging this pull request may close these issues.
3 participants
@andygrove @jlowe @sameerz