Use scala Int.box instead of Integer constructors #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
force-pushed
the
bug/use_scala_box
branch
from
02ca291 to
8e90deb
Compare
…n JDK11 Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
mythrocks
previously approved these changes
Dec 9, 2021
jlowe
previously approved these changes
Dec 9, 2021
|
build |
gerashegalov
previously approved these changes
Dec 9, 2021
| @@ -165,7 +165,7 @@ object RapidsShuffleTestHelper extends MockitoSugar with Arm { | |||
| } | |||
|
|
|||
| def withMockContiguousTable[T](numRows: Long)(body: ContiguousTable => T): T = { | |||
| val rows: Seq[Integer] = (0 until numRows.toInt).map(new Integer(_)) | |||
| val rows: Seq[Integer] = (0 until numRows.toInt).map(Int.box) | |||
There was a problem hiding this comment.
nit:
Suggested change
| val rows: Seq[Integer] = (0 until numRows.toInt).map(Int.box) | |
| val rows: Seq[Integer] = (0 until numRows).map(Int.box) |
There was a problem hiding this comment.
sorry, that was a bad comment, scalac won't do a silent lossy conversion for us. I'll undo it
There was a problem hiding this comment.
@gerashegalov no problem, the constructor (I was trying not to use) also came back with the revert, but I changed it back to Int.box. Please take another look!
Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
abellina
dismissed stale reviews from gerashegalov, jlowe, and mythrocks
via
2015c2f
|
build |
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
gerashegalov
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for the test code where it was using
new Integerinstead ofInt.box. The integer constructors were deprecated in JDK 11, so this is not a must have for us, but it is not a great user experience to have the plugin fail to build because of this.@sameerz up to you if I should target this to 21.12. @jlowe @revans2 fyi.