Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation link, clarify documentation [skip ci] #4683

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

sameerz
Copy link
Collaborator

@sameerz sameerz commented Feb 2, 2022

Signed-off-by: Sameer Raheja sraheja@nvidia.com

Documentation updates:

  1. Fixes link on README.md
  2. Clarifies information about testing on integration test README page.

Fixes #4678, fixes #4679

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz sameerz added the documentation Improvements or additions to documentation label Feb 2, 2022
@sameerz sameerz added this to the Jan 31 - Feb 11 milestone Feb 2, 2022
@sameerz sameerz self-assigned this Feb 2, 2022
@jlowe jlowe changed the title Fix documentation link, clarify documentation Fix documentation link, clarify documentation [skip ci] Feb 2, 2022
@jlowe
Copy link
Contributor

jlowe commented Feb 2, 2022

build

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is a diff and why we need it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the previous version of the file did not end with a \n character, and this one does. Not sure why it would not have? I can remove it if people prefer, or leave it as is and merge.

Related: https://thoughtbot.com/blog/no-newline-at-end-of-file

@sameerz sameerz merged commit a9c05d0 into NVIDIA:branch-22.04 Feb 3, 2022
@sameerz sameerz deleted the branch-22.02-fix-README branch April 21, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
3 participants