Fix approximate percentile reduction UnsupportedOperationException #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to retarget this to 22.04 |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
approx-percentile-bug
branch
from
93a498a to
0429dd4
Compare
andygrove
changed the title
|
build |
abellina
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5159
The integration tests for approx percentile did not cover the cases where
com.nvidia.spark.rapids.GpuApproximatePercentile#initialValuesis used and this had not been implemented.This PR adds a test that reproduces the issue, and implements
initialValuesto produce a t-digest literal with no centroids and zero for min and max.