Fix column->row conversion GPU check: #5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#5181. The change in NVIDIA#5122 modifies the row->column conversion code to run differently on Pascal GPUs. It does so by checking the GPU architecture to detect whether the current device is Pascal. In a distributed setup, this check should run on the Spark executor. As it currently stands, the check is erroneously run on the driver. This fix postpones the GPU architecture check till the executor task attempts to fetch result rows. Signed-off-by: MithunR <mythrocks@gmail.com>
|
I have yet to verify that this works in a distributed setup. I'll move this out of draft as soon as that's verified. |
|
Build |
jlowe
previously approved these changes
Apr 9, 2022
|
@mythrocks did you intend to target this to 22.04? |
|
Yes, sir. The GPU arch check is in 22.04 already. :/ |
|
Sorry, I haven't yet confirmed that this change is adequate. |
|
Nope, sorry. I'll have to pick this up on Monday. |
|
Apologies for the prolonged delay. I have now confirmed that this patch fixes #5181. |
|
build |
jlowe
approved these changes
Apr 11, 2022
|
Build |
|
build |
|
@pxLi : Thank you for checking this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5181.
The change in #5122 modifies the row->column conversion code to run
differently on Pascal GPUs. It does so by checking the GPU architecture
to detect whether the current device is Pascal.
In a distributed setup, this check should run on the Spark executor. As it
currently stands, the check is erroneously run on the driver.
This fix postpones the GPU architecture check till the executor task attempts
to fetch result rows.
Signed-off-by: MithunR mythrocks@gmail.com