-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple datatypes in TypeSig.withPsNote()
#5277
Merged
jlowe
merged 7 commits into
NVIDIA:branch-22.06
from
HaoYang670:issue5203_multi_types_withpsnote
Apr 21, 2022
Merged
Support multiple datatypes in TypeSig.withPsNote()
#5277
jlowe
merged 7 commits into
NVIDIA:branch-22.06
from
HaoYang670:issue5203_multi_types_withpsnote
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
build |
Signed-off-by: remzi <13716567376yh@gmail.com>
build |
jlowe
reviewed
Apr 19, 2022
spark2-sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: remzi <13716567376yh@gmail.com>
build |
1 similar comment
build |
jlowe
reviewed
Apr 20, 2022
spark2-sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala
Outdated
Show resolved
Hide resolved
jlowe
reviewed
Apr 20, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala
Outdated
Show resolved
Hide resolved
…hecks.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
…cala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
build |
jlowe
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
close #5203
Add a new API for
withPSNote
which can mark multi datatypes with same note.