Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualification tool: Parsing Execs to get the ExecInfo #1 #5420

Merged
merged 3 commits into from
May 4, 2022

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented May 4, 2022

This partially addresses #5361. Out of 12 execs in the issue, 7 are supported in this PR. I will create a follow on PR(s) for the remaining ones.
Execs supported in this PR:

  • CoalesceExec
  • CollectLimitExec
  • ExpandExec
  • RangeExec
  • SampleExec
  • TakeOrderedAndProjectExec
  • UnionExec

Added unit test which creates event logs on the fly and verifies if the Execs are supported and the scores associated with those.

@nartal1 nartal1 added the tools label May 4, 2022
@nartal1 nartal1 added this to the May 2 - May 20 milestone May 4, 2022
@nartal1 nartal1 requested a review from tgravescs May 4, 2022 01:01
@nartal1 nartal1 self-assigned this May 4, 2022
@tgravescs
Copy link
Collaborator

build

@tgravescs
Copy link
Collaborator

Please list execs contained here in the description

Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build

@tgravescs
Copy link
Collaborator

build

@tgravescs tgravescs merged commit a5733d2 into NVIDIA:branch-22.06 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants