-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shims for Spark 3.4.0 #5472
Conversation
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
For early review. And there are 21 unit tests failing, also failing on 330, tracked by #5457.
|
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
PR is blocked by #5457. Keep draft |
A follow-up issue #5495 |
build |
CI failed, since the premerge build requires updates accordingly. Waiting for 22.08. |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
A new follow-up #5589 |
build |
sql-plugin/src/main/scala/com/nvidia/spark/rapids/CostBasedOptimizer.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
build |
sql-plugin/src/main/340/scala/com/nvidia/spark/rapids/shims/GlobalLimitShims.scala
Show resolved
Hide resolved
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be tests on 340+ to verify we're properly falling back on the limit-with-offset scenarios, as it's silent data corruption if we don't get that correct.
sql-plugin/src/main/340/scala/com/nvidia/spark/rapids/SparkShims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/340/scala/com/nvidia/spark/rapids/SparkShims.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Added tests for it |
build |
* Add shims for Spark 340 Signed-off-by: Firestarman <firestarmanllc@gmail.com>
This PR is to add shims for Spark 3.4.0.
It has mainly
Parquet
.ShimFilePartitionReaderFactory
being the parent of the Rapids PERFILE readers, to hide the changes in Spark 3.4.0.closes #5128
closes #5495
Signed-off-by: Firestarman firestarmanllc@gmail.com