Update the error checking of test_cast_neg_to_decimal_err
#5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
pxLi
reviewed
May 31, 2022
| @@ -294,6 +294,7 @@ def test_mod_pmod_by_zero(data_gen, overflow_exp): | |||
| ansi_enabled_conf, | |||
| exception_str) | |||
|
|
|||
| @pytest.mark.skipif(is_spark_314() or is_spark_322(), reason="Spark 3.1.4 and 3.2.2 will return null instead of throwing exception") | |||
There was a problem hiding this comment.
what about spark 33X, 34X? it would be nice to have better context for this condition
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
|
what Spark change does this map back to? I would like to make sure this as intentional as it seems odd to change it to not throw |
HaoYang670
changed the title
test_cast_neg_to_decimal_err for Spark 314 and 322test_cast_neg_to_decimal_err
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
HaoYang670
changed the title
test_cast_neg_to_decimal_errtest_cast_neg_to_decimal_err
tgravescs
reviewed
Jun 6, 2022
| exception_str = "java.lang.ArithmeticException: " + exception_content if is_before_spark_330() \ | ||
| and not is_databricks104_or_later() else "org.apache.spark.SparkArithmeticException: " \ | ||
| + exception_content | ||
| exception_str = "java.lang.ArithmeticException: " if is_before_spark_330() \ |
There was a problem hiding this comment.
this doesn't really match what we have done for other tests, other tests we check the message but differentiate versions. We were trying to match the exceptions as close as possible.
We also have #5196 which is to make exceptions match.
so I would rather see us go that direction
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
tgravescs
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Closes #5683.
Spark has updated the error message of decimal overflow: https://issues.apache.org/jira/browse/SPARK-39060
We should also match the update.
Affected versions: 3.1.x (x >= 4), 3.2.x (x >= 2), 3.3.x (x >= 0), 3.4