Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily allow 3.3.1 for 3.3.0 shims. #5693

Merged
merged 1 commit into from
May 31, 2022
Merged

Temporarily allow 3.3.1 for 3.3.0 shims. #5693

merged 1 commit into from
May 31, 2022

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented May 31, 2022 •
edited
Loading

Temporarily allow 3.3.1 while 3.3.0 release candidates are being produced. Since we need to catch up the latest updates for Spark 3.3.0 shims.

Signed-off-by: Firestarman firestarmanllc@gmail.com

@firestarman
Temporarily allow 3.3.1 for 3.3.0 shims.
52e2dbf 
Temporarily allow 3.3.1 while 3.3.0 release candidates are being produced

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

build

@pxLi pxLi added the build Related to CI / CD or cleanly building label May 31, 2022
tgravescs
tgravescs approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems ok, but we need a P1 for 22.06 to remove this

@tgravescs tgravescs mentioned this pull request May 31, 2022
Closed
@tgravescs
Copy link
Collaborator

#5698

@tgravescs tgravescs merged commit 53cfa49 into NVIDIA:branch-22.06 May 31, 2022
tgravescs added a commit that referenced this pull request May 31, 2022
@tgravescs @firestarman
Temporarily allow 3.3.1 for 3.3.0 shims. (#5693) (#5700)
15fad2a 
Temporarily allow 3.3.1 while 3.3.0 release candidates are being produced

Signed-off-by: Firestarman <firestarmanllc@gmail.com>

Co-authored-by: Liangcai Li <firestarmanllc@gmail.com>
@sameerz sameerz added this to the May 23 - Jun 3 milestone Jun 1, 2022
@firestarman firestarman deleted the 331-for-330 branch June 8, 2022 01:12
pxLi added a commit to pxLi/spark-rapids that referenced this pull request Jun 16, 2022
@pxLi
Revert "Temporarily allow 3.3.1 for 3.3.0 shims. (NVIDIA#5693)"
2066a06 
This reverts commit 53cfa49.
@pxLi pxLi mentioned this pull request Jun 16, 2022
Merged
pxLi added a commit that referenced this pull request Jun 16, 2022
@pxLi
Update spark330shim to use released lib (#5848)
d1f601a 
* Revert "Temporarily allow 3.3.1 for 3.3.0 shims. (#5693)"

This reverts commit 53cfa49.

* update shim330 dep to released spark 330 libs

Signed-off-by: Peixin Li <pxli@nyu.edu>

* drop 330 from snapshot section in buildall
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@jlowe jlowe Awaiting requested review from jlowe

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@zhanga5 zhanga5 Awaiting requested review from zhanga5

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
May 23 - Jun 3
Development

Successfully merging this pull request may close these issues.
4 participants
@firestarman @tgravescs @sameerz @pxLi